tests/core/executions/WinCheckExecution.test.ts (1)

572-603: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Add a post-grace assertion for simultaneous disconnects.

This test only checks “not immediate winner.” Please also advance beyond grace and assert winner-by-tiles, so this contract is locked by tests.

Suggested test extension

   test("should not set winner immediately when both players disconnect", async () => {
@@
     const human1 = game.player("Player1");
     const human2 = game.player("Player2");

+    // Make winner deterministic for post-grace check
+    let assigned = 0;
+    game.map().forEachTile((tile) => {
+      if (!game.map().isLand(tile)) return;
+      if (assigned < 1) {
+        human1.conquer(tile);
+        assigned++;
+      }
+    });
+
     human1.markDisconnected(true);
     human2.markDisconnected(true);
@@
     winCheck.checkWinnerFFA();

     // No grace timer was started (both disconnected simultaneously)
     expect(setWinnerSpy).not.toHaveBeenCalled();
     expect(winCheck.isActive()).toBe(true);
+
+    game.endSpawnPhase();
+    for (let i = 0; i < 310; i++) {
+      game.executeNextTick();
+    }
+    winCheck.checkWinnerFFA();
+    expect(setWinnerSpy).toHaveBeenCalledWith(human1, expect.anything());
+    expect(winCheck.isActive()).toBe(false);
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/core/executions/WinCheckExecution.test.ts` around lines 572 - 603,
Extend the test to also verify the post-grace outcome: after the initial
assertions, advance the test timer/passage of time beyond the grace period (or
call the WinCheckExecution method that processes end-of-grace), then invoke the
win-checking logic again (e.g., call winCheck.checkWinnerFFA() or the
appropriate tick/resolve method on WinCheckExecution) and assert that
game.setWinner (setWinnerSpy) is called with the expected winner reason
(winner-by-tiles) and that winCheck.isActive() is false; reference
WinCheckExecution, winCheck.checkWinnerFFA(), winCheck.isActive(), and the
setWinnerSpy assigned to game.setWinner when adding these steps.